Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server.rst #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterschristoph
Copy link

add debian 10 requirements, for easier setup.

on debian 10 the system packet "libnetfilter-conntrack-dev" is definitely missing in the docs otherwise the installation will abort at the legacy branch.

add debian 10 requirements
@@ -147,7 +158,7 @@ If we assume that you are installing Tunneldigger under ``/srv/tunneldigger``
virtualenv -p /usr/bin/python3 env_tunneldigger

.. note::
Tunneldigger only supports Python 3.
Latest Tunneldigger only supports Python 3.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confusing, because the "stable" version shown as v0.3.0 is working under python 2.7.

Maybe someone can delete the "stable" read the docs version or update this? how can something be stable if it runs under python 2.7?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is related to #145?

Copy link
Member

@RalfJung RalfJung Oct 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think docs should retrace the history of all things that used to be supported in the past. Also, everything the docs say only applies to latest tunneldigger. It would be more confusing to emphasize this here as that might be read to imply that some of the rest of the docs also apply to older tunneldigger, which they do not. (They might happen to, but that is a coincidence. These are docs for the latest version and the latest version only.)

@@ -115,6 +115,13 @@ Also the following Debian packages are required:
* ``python-dev``
* ``libevent-dev``

Debian 10 required following packages:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we give a distro here, we should also give a distro above -- or replace the above list.

* ``bridge-utils``
* ``python-dev``
* ``libevent-dev``
* ``libnetfilter-conntrack-dev``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This packet is not required any more as far as I know -- we do not have it installed on our servers and tunneldigger works fine there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants